Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log spam from Taskcluster API calls during optimization #400

Closed
ahal opened this issue Dec 19, 2023 · 1 comment
Closed

Log spam from Taskcluster API calls during optimization #400

ahal opened this issue Dec 19, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ahal
Copy link
Collaborator

ahal commented Dec 19, 2023

I noticed that since Taskgraph 7.0.0, we're getting a lot of logspam like:

[task 2023-12-19T19:13:01.410Z] 2023-12-19 19:13:01,410 - WARNING - response body: {
[task 2023-12-19T19:13:01.410Z]   "code": "ResourceNotFound",
[task 2023-12-19T19:13:01.410Z]   "message": "Indexed task not found\n\n---\n\n* method:     findTask\n* errorCode:  ResourceNotFound\n* statusCode: 404\n* time:       2023-12-19T19:13:01.408Z",
[task 2023-12-19T19:13:01.410Z]   "requestInfo": {
[task 2023-12-19T19:13:01.410Z]     "method": "findTask",
[task 2023-12-19T19:13:01.410Z]     "params": {
[task 2023-12-19T19:13:01.410Z]       "indexPath": "project.glean.cache.head.taskgraph_upgrade.docker-images.v2.linux.hash.6efbc0e1bab58aa89baa4c8dc2537bc1d8e8a52f101ab9de3afee597fd5b87fc"
[task 2023-12-19T19:13:01.410Z]     },
[task 2023-12-19T19:13:01.410Z]     "payload": {},
[task 2023-12-19T19:13:01.410Z]     "time": "2023-12-19T19:13:01.408Z"
[task 2023-12-19T19:13:01.410Z]   }
[task 2023-12-19T19:13:01.410Z] }

In Decision task logs. This is due to:
4f364e6

We neglected to consider that during optimization, a 404 is totally expected and normal. This isn't really a "bug" per se, but we should find a way to fix this before upgrading Gecko to Taskgraph 7+, otherwise the logs are going to have 1000s of these.

@ahal ahal added the bug Something isn't working label Dec 19, 2023
@jcristau
Copy link
Contributor

IMO we should revert #327. Sorry about this.

ahal added a commit to ahal/taskgraph that referenced this issue Dec 20, 2023
@ahal ahal self-assigned this Dec 20, 2023
ahal added a commit that referenced this issue Dec 20, 2023
@ahal ahal closed this as completed Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants