Skip to content
This repository has been archived by the owner on Feb 27, 2020. It is now read-only.

Uploading empty artifact S3 causes 501 #375

Closed
jonasfj opened this issue Apr 25, 2018 · 3 comments
Closed

Uploading empty artifact S3 causes 501 #375

jonasfj opened this issue Apr 25, 2018 · 3 comments

Comments

@jonasfj
Copy link
Contributor

jonasfj commented Apr 25, 2018

credits @bclary for reporting it.

For some reason the error from my integration test was suppressed initially, that's fixed now...
Which means we can reproduce it...

@jonasfj
Copy link
Contributor Author

jonasfj commented Apr 25, 2018

Empty artifacts is broken, because contentLength zero is the default value... so golang/http assumes you didn't set contentLength uses transfer-encoding: chunked, which S3 doesn't support.

Fun bug which probably requires a work-around: golang/go#20257

Hmm, maybe I can patch my fake S3 implementation to check a content-length is present :)

@jonasfj
Copy link
Contributor Author

jonasfj commented Apr 25, 2018

Fix added to #373

@jonasfj
Copy link
Contributor Author

jonasfj commented Apr 30, 2018

Fixed

@jonasfj jonasfj closed this as completed Apr 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant