This repository has been archived by the owner on Feb 27, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
Uploading empty artifact S3 causes 501 #375
Comments
jonasfj
added a commit
that referenced
this issue
Apr 25, 2018
Empty artifacts is broken, because contentLength zero is the default value... so golang/http assumes you didn't set contentLength uses transfer-encoding: chunked, which S3 doesn't support. Fun bug which probably requires a work-around: golang/go#20257 Hmm, maybe I can patch my fake S3 implementation to check a content-length is present :) |
jonasfj
added a commit
that referenced
this issue
Apr 25, 2018
Fix added to #373 |
jonasfj
added a commit
that referenced
this issue
Apr 29, 2018
jonasfj
added a commit
that referenced
this issue
Apr 29, 2018
jonasfj
added a commit
that referenced
this issue
Apr 29, 2018
Fixed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
credits @bclary for reporting it.
For some reason the error from my integration test was suppressed initially, that's fixed now...
Which means we can reproduce it...
The text was updated successfully, but these errors were encountered: