Refresh codebase, use Taskcluster CI #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new Buffer(array or size) was deprecated in v6, emits a warning in v10 or later.
jwhitlock
force-pushed
the
taskcluster-ci
branch
from
60ed99e to
38e2eaf
Compare
Upgrade with `yarn upgrade` to upgrade all dependencies that don't include major versions breaking the specifications in package.json.
* Change eslint rules from deprecated to supported commands. * Use "ignore", "warn", "error" instead of 0, 1, 2. * Update to Node.js v10 syntax, and set v10 as minimal version. * Run "eslint --fix src test"
The mocha.opts file is no longer used. They are now in the package.json file, and other locations are possible.
Use "yarn install --ignore-engines", which is also need to test odd-numbered releases like v15.
The test suite setup includes running an ubuntu container with "sleep 600". This means that the one created by test/runtests.sh is unused and unneccesary. I removed the script and now call mocha directly, which allows passing environment variables and extra commands when running tests. I left docker-compose.yml, but there is the option of using the (more complex) raw docker commands. The test suite was not automatically closing because the HTTP servers were still listening. I added these to the "after" section, and now the tests exit themselves, and --exit is no longer required.
The `wc -c` call should return 3 characters.
Test no longer execute on node v8. Tests pass on node v10, although package.json specifies v12 as the minimum supported version.
jwhitlock
changed the title
|
I've tested locally that this passes against taskcluster/docker-exec-websocket-server#35. Once that is merged and a new package released, I can update and get tests passing here as well. |
Add improvements from docker-exec-webclient-server
|
Tests are passing with the just-released |
jwhitlock
force-pushed
the
taskcluster-ci
branch
from
f7e6f53 to
245814c
Compare
When running with an auto-allocated TTY, the test output is often omitted from the live log.
jwhitlock
force-pushed
the
taskcluster-ci
branch
from
245814c to
4edabaf
Compare
matt-boris
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to parallel the changes in taskcluster/docker-exec-websocket-server#35. The tests use
docker-exec-websocket-server, and pass when run against v3.0.0.WebSocket, which will callsocket.destroy()on the underlying Node socket.mocha --exit(thanks to Stack Overflow commenter Martin P for suggesting why-is-node-running)new Buffer(<array or size>)(deprecation warning) toBuffer.from(array)andBuffer.alloc(size).docker-exec-websocket-servertodocker-exec-websocket-clientes-lintto 8.8, upgrade.eslintrc, and fix issuesmochato 9.2.0, migrate settings frommocha.optstopackage.jsondocker-exec-websocket-serverto 3.0.0, which fixes the testsdocker-compose, which it downloads and installs.tests/runtests.sh, since the test setup creates its ownubuntucontainer for testing.