Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyCharm support #108

Closed
wants to merge 1 commit into from
Closed

Add PyCharm support #108

wants to merge 1 commit into from

Conversation

aploium
Copy link

@aploium aploium commented Oct 7, 2016

Please see Issue #107

@aploium aploium changed the title Add PyCharm support #107 Add PyCharm support Oct 7, 2016
@wiggin15
Copy link
Collaborator

Hi. I think the check will fit more neatly in ansitowin32.py where the default strip/convert values are determined. Maybe we can add the PyCharm check to conversion_supported, or directly to the lines that determine strip and convert: https://github.com/tartley/colorama/blob/master/colorama/ansitowin32.py#L74 and https://github.com/tartley/colorama/blob/master/colorama/ansitowin32.py#L79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants