Highlight colors not changing after toggling modus themes

[8dcc]

Hello, I am using the version 4.3.0 of modus themes, and whenever I run modus-themes-toggle, the colors change for everything except the hl-todo keywords. This can be fixed by reverting the buffers or by calling something like font-lock-fontify-buffer or font-lock-flush.

I was wondering if this issue is caused by this package, or by the modus themes; and if I could fix this on my config by hooking some function to modus-themes-after-load-theme-hook (one that flushes all buffers, not just the current one).

I am using this hl-todo package on commit 70ce484.

Thanks in advance.

[tarsius]

hl-todo doesn't define any faces, instead it defines a single variable, an alist, which maps keywords to color strings. The face that is used as the value of the font-lock-face text property isn't something like hl-todo-done-keyword, but ((:foreground #afd8af") hl-todo). (So actually there is one face hl-todo, but it is always combined with an explicitly named color.

I assume modus-themes does theme the hl-todo-keyword-faces variable, and when you toggle a theme on or off, that does change the value of that variable, but doing so does not change the values of the font-lock-face text property across all text in all buffers.

You should be able to deal with it by additionally turning off and then on again global-hl-todo-mode.

[8dcc]

I see, so it's a modus issue, not a hl-todo issue/bug. Excuse me.

[tarsius]

No, its a design decision. In hl-todo.

It has this unfortunate side-effect, but I think that is okay; as I mentioned you just have to shake the major-mode a bit. 😀

[tarsius]

Ps: You ignored this:

🆘 Request help ☛ please open a discussion instead of an issue
Please search, ask and answer questions here.

[8dcc]

In case anyone else found this discussion and is interested in a possible fix:

(add-hook 'modus-themes-after-load-theme-hook
            (lambda ()
              (dolist (buf (buffer-list))
                (with-current-buffer buf
                  (when hl-todo-mode
                    (font-lock-flush))))))

I am sure it can be improved, but it seems to work.