Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the swisscard importer work with the new statement CSV format. #111

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

5Ub-Z3r0
Copy link
Contributor

@5Ub-Z3r0 5Ub-Z3r0 commented Jul 5, 2024

Somewhen between Jun 4th and Jul 5th, the swisscard statements in CSV format moved from a single Category column to:

  • a "Merchant Category" column, which looks like a general category for the merchant.
  • a "Registered Category" column, which looks like a string version of the ISO standard MCC code.

Since all statements, previous and past, are now issued with the updated format, it's safe to just modify the importer to make use of the split columns as metadata.

5Ub-Z3r0 added 3 commits July 5, 2024 21:26
Somewhen between Jun 4th and Jul 5th, the swisscard statements in CSV
format moved from a single Category column to:

- a "Merchant Category" column, which looks like a general category for
the merchant.
- a "Registered Category" column, which looks like a string version
of the ISO standard MCC code.

Since all statements, previous and past, are now issued with the updated
format, it's safe to just modify the importer to make use of the split
columns as metadata.
@tarioch
Copy link
Owner

tarioch commented Jul 5, 2024

I just created #112 as this is the first time to do changes since beancount 3 was released and for now I have to stick with beancount 2 (waiting for fava to upgrade first). Will get that PR merged soon, if you can rebase afterwards, it should hopefully resolve the issues you have on this PR.

@tarioch
Copy link
Owner

tarioch commented Jul 5, 2024

Just merged it, can you rebase please? and thank you for your contribution

@5Ub-Z3r0
Copy link
Contributor Author

5Ub-Z3r0 commented Jul 5, 2024

Sure thing, done.

@tarioch tarioch added the bugfix label Jul 5, 2024
@tarioch tarioch merged commit 5d4fa30 into tarioch:master Jul 5, 2024
2 checks passed
@tarioch
Copy link
Owner

tarioch commented Jul 5, 2024

Merged, thank you very much, I'll trigger a release right away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants