Some of the dividends don't have the "PER SHARE" sub-string #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. "description='IFN (USx) STOCK DIVIDEND USx x FOR 1000000000 (Ordinary Dividend)'"
|
Thank you very much for your contribution, looks like there are some pre-commit checks failing. Can you please adjust? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi :)
While most of the dividends are with this kind of description:
description='BAH(Ux) CASH DIVIDEND USD 0.47 PER SHARE (Ordinary Dividend)'some are of this form:
description='IFN (USx) STOCK DIVIDEND USx x FOR 1000000000 (Ordinary Dividend)'This will cause an
AttributeError: 'NoneType' object has no attribute 'group'as no "PER SHARE" is found.