Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revolut importer is missing meta field when returning a balance #77

Closed
kosli opened this issue Nov 24, 2022 · 1 comment
Closed

Revolut importer is missing meta field when returning a balance #77

kosli opened this issue Nov 24, 2022 · 1 comment

Comments

@kosli
Copy link

kosli commented Nov 24, 2022

I have problems using the Revolut importer with https://github.com/jbms/beancount-import
If the Revolut importer returns a balance, it is not providing the meta field and so beancount-import fails due to the missing filename.

entry = data.Balance(meta, book_date, self.account, balance, None, None)

The importer should have the meta variable set too, like it does for transactions:

meta = data.new_metadata(file.name, 0, metakv)

At least the sample importers of beancount are providing the meta with balance entries too:
https://github.com/beancount/beancount/tree/v2/beancount/ingest/importers/

I'll try to test and submit a PR later on.

tarioch added a commit that referenced this issue Nov 25, 2022
Add metadata for balance entries, fixes #77
@kosli
Copy link
Author

kosli commented Nov 26, 2022

Thanks @tarioch Works like a charm now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant