Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wallet grpc get fee for template registration #6706

Conversation

ksrichard
Copy link
Contributor

Description

For Tari CLI I needed a new grpc method on wallet to get the calculated fee for a new template registration.

Motivation and Context

How Has This Been Tested?

What process can a PR reviewer use to test or verify this change?

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@ksrichard ksrichard requested a review from a team as a code owner November 27, 2024 14:02
Copy link

github-actions bot commented Nov 27, 2024

Test Results (CI)

    3 files    129 suites   39m 11s ⏱️
1 341 tests 1 341 ✅ 0 💤 0 ❌
4 021 runs  4 021 ✅ 0 💤 0 ❌

Results for commit e7e5c9f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 27, 2024

Test Results (Integration tests)

36 tests   36 ✅  15m 10s ⏱️
11 suites   0 💤
 2 files     0 ❌

Results for commit e7e5c9f.

♻️ This comment has been updated with latest results.

@ksrichard ksrichard marked this pull request as draft November 28, 2024 09:48
@ksrichard ksrichard marked this pull request as ready for review November 28, 2024 13:27
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

utACK

@sdbondi sdbondi merged commit 9aaa364 into tari-project:feature-dan2 Nov 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants