feat: trickle validators #6660
Merged
feat: trickle validators #6660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 129 suites 41m 30s ⏱️ Results for commit 7ff6931. ♻️ This comment has been updated with latest results. |
Test Results (Integration tests) 2 files 11 suites 24m 8s ⏱️ For more details on these failures, see this check. Results for commit 7ff6931. ♻️ This comment has been updated with latest results. |
base_layer/core/src/chain_storage/lmdb_db/validator_node_store.rs
Outdated
Show resolved
Hide resolved
base_layer/core/src/chain_storage/lmdb_db/validator_node_store.rs
Outdated
Show resolved
Hide resolved
|
Interesting approach. LGTM, apart form failing clippy and tests. |
sdbondi
force-pushed
the
feature/trickle-validators
branch
from
519b945
to
7ff6931
Compare
sdbondi
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We allow here only a configured (in Consensus constants) number of validator nodes to be active in an epoch, so this way we avoid having way too much validators appear at the same time.
All the validator nodes are saved to the blockchain database, when there is a new validator node registration UTXO, but with a different
start epochthat is calculated from the already saved validator nodes.There is a new gRPC method called
GetValidatorNodeChanges, where we can ask base node to give back all the validator node additions and deletions in the given start/end height range.When Layer-2 scans new blocks and sees that there is a change in the validator node set, simply calls this new grpc method and adds/removes validator nodes. This way base node controls fully how many nodes are registered at which epoch.
Motivation and Context
Layer-2 validator nodes are registered all at once when they were added to the chain with a special UTXO, but it allows to register too many nodes at the same time, so consensus can catch up much slower.
How Has This Been Tested?
What process can a PR reviewer use to test or verify this change?
Breaking Changes