Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prepare MM backend stuff #6448

Merged

Conversation

SWvheerden
Copy link
Collaborator

Description

This removes a few panics, and adds in a fake mainnet block.
Duplicates stagenet consensus values for mainnet.

Motivation and Context

As we are getting closer to mainnet, we need to ensure that we can test all of the features. This adds in a temporary mainnet block to use in local testing. This block will not be the final one and will only be a place holder.

How Has This Been Tested?

unit tests

@SWvheerden SWvheerden requested a review from a team as a code owner August 5, 2024 13:41
Copy link

github-actions bot commented Aug 5, 2024

Test Results (CI)

    3 files    123 suites   40m 51s ⏱️
1 300 tests 1 300 ✅ 0 💤 0 ❌
3 892 runs  3 892 ✅ 0 💤 0 ❌

Results for commit 7d0e5cf.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

Test Results (Integration tests)

 2 files   1 errors  9 suites   26m 13s ⏱️
19 tests 17 ✅ 0 💤 2 ❌
22 runs  19 ✅ 0 💤 3 ❌

For more details on these parsing errors and failures, see this check.

Results for commit 7d0e5cf.

♻️ This comment has been updated with latest results.

@@ -2103,7 +2103,6 @@ async fn manage_multiple_transactions() {

let database_path = temp_dir.path().to_str().unwrap().to_string();

// TODO: When using a memory type db connection this test fails at `assert_eq!(tx_reply, 3, "Need 3 replies");`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been fixed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but the test does not need a memory db, and if that's still an issue, log an issue. Todo's don't belong in code

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe then convert it to a normal comment for the next maintainer that may struggle with it? Probably not worth an issue.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@SWvheerden SWvheerden merged commit 47ddf85 into tari-project:development Aug 6, 2024
15 of 17 checks passed
@SWvheerden SWvheerden deleted the sw_make_mainnet_ready branch August 7, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants