-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: prepare MM backend stuff #6448
feat: prepare MM backend stuff #6448
Conversation
Test Results (CI) 3 files 123 suites 40m 51s ⏱️ Results for commit 7d0e5cf. ♻️ This comment has been updated with latest results. |
Test Results (Integration tests) 2 files 1 errors 9 suites 26m 13s ⏱️ For more details on these parsing errors and failures, see this check. Results for commit 7d0e5cf. ♻️ This comment has been updated with latest results. |
@@ -2103,7 +2103,6 @@ async fn manage_multiple_transactions() { | |||
|
|||
let database_path = temp_dir.path().to_str().unwrap().to_string(); | |||
|
|||
// TODO: When using a memory type db connection this test fails at `assert_eq!(tx_reply, 3, "Need 3 replies");` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this been fixed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but the test does not need a memory db, and if that's still an issue, log an issue. Todo's don't belong in code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe then convert it to a normal comment for the next maintainer that may struggle with it? Probably not worth an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Co-authored-by: Hansie Odendaal <[email protected]>
3147a69
to
7d0e5cf
Compare
Description
This removes a few panics, and adds in a fake mainnet block.
Duplicates stagenet consensus values for mainnet.
Motivation and Context
As we are getting closer to mainnet, we need to ensure that we can test all of the features. This adds in a temporary mainnet block to use in local testing. This block will not be the final one and will only be a place holder.
How Has This Been Tested?
unit tests