fix: rewind bug causing SMT to be broken #6172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
the
CR-insufficient_context
Test Results (CI) 3 files 117 suites 42m 0s ⏱️ Results for commit eb88735. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests)12 tests +12 12 ✅ +12 1m 2s ⏱️ + 1m 2s For more details on these parsing errors, see this check. Results for commit eb88735. ± Comparison against base commit c6f2b8d. ♻️ This comment has been updated with latest results. |
SWvheerden
changed the title
ghpbot-tari-project
removed
P-reviews_required
SWvheerden
changed the title
ghpbot-tari-project
added
the
P-reviews_required
hansieodendaal
approved these changes
Mar 1, 2024
Comment on lines
+1021
to
+1029
| let smt_node = ValueHash::try_from(input.smt_hash(utxo_mined_info.mined_height).as_slice())?; | ||
| if let Err(e) = output_smt.insert(smt_key, smt_node) { | ||
| error!( | ||
| target: LOG_TARGET, | ||
| "Output commitment({}) already in SMT", | ||
| input.commitment()?.to_hex(), | ||
| ); | ||
| return Err(e.into()); | ||
| } |
ghpbot-tari-project
removed
the
P-reviews_required
4 tasks
SWvheerden
pushed a commit
that referenced
this pull request
Mar 1, 2024
Description --- Fixed cucumber network environment Motivation and Context --- The cucumber environment uses a single runtime environment and the network should be set prior to use. Fixes cucumber test failures introduced by #6170. How Has This Been Tested? --- Applicable cucumber pass What process can a PR reviewer use to test or verify this change? --- Verify that `Scenario: Clear out mempool` passes **Note:** #6172 also introduced other cucumber errors <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes rewind bug in the SMT
Makes SMT instructions more strict.
Updates logs to give a clearer indication as to what happens