feat: update faucets #6024
Merged
feat: update faucets #6024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
Update the faucets and initial emission values for esmeralda, igor, stagenet and nextnet.
hansieodendaal
force-pushed
the
ho_consensus_initial_emission
branch
from
e515007
to
21fd26a
Compare
SWvheerden
approved these changes
Dec 8, 2023
ghpbot-tari-project
removed
the
P-reviews_required
4 tasks
SWvheerden
pushed a commit
that referenced
this pull request
Dec 9, 2023
Description --- Added more faucet tests, updated constants Motivation and Context --- This should have been part of #6024 How Has This Been Tested? --- New unit tests What process can a PR reviewer use to test or verify this change? --- <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the faucets and initial emission values for esmeralda, stagenet and nextnet.
Note: The igor faucet has been uploaded but not activated.
Motivation and Context
Faucet values were not accounted for in the total emission.
How Has This Been Tested?
Existing unit tests pass.
Updated unit test
fn esmeralda_schedule().Updated the esmeralda, stagenet and nextnet genesis blocks with new faucet MMR information.
What process can a PR reviewer use to test or verify this change?
Code walk-through
Run the unit test
Breaking Changes
BREAKING CHANGE: The block chain needs to be started from scratch