feat(node grpc): add grpc authentication to the node #5928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
brianp
force-pushed
the
node-grpc-authentication
branch
from
e446353
to
572e90f
Compare
There was a problem hiding this comment.
Looks good, although I think we should consider using the same approach defined in #5936?
SWvheerden
approved these changes
Nov 13, 2023
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds basic auth to the minotari node.
Adds support on the Miner, and MergeMiner Proxy for node basic auth credentials.
Motivation and Context
Make things just that much more secure.
How Has This Been Tested?
Locally running a node, wallet, and miner. (MergeMiner untested).
Breaking Changes