Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support tls-based auth for grpc (WIP) #5897

Closed
wants to merge 1 commit into from
Closed

feat: support tls-based auth for grpc (WIP) #5897

wants to merge 1 commit into from

Conversation

hnidoaht-101
Copy link
Contributor

@hnidoaht-101 hnidoaht-101 commented Nov 2, 2023 •
edited
Loading

Description

Added support SSL/TLS based authentication and transport security for gRPC.
Resolving #5808

Motivation and Context

See #5808

How Has This Been Tested?

  • Pass unit tests.
  • Add more unit test.

What process can a PR reviewer use to test or verify this change?

  • Code walkthrough.
  • Running bash script from the root project: $ bash scripts/keygen.sh [hostname], default is tari.local if no argument is provided.
  • Manual gRPC queries.

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Nov 2, 2023
@AaronFeickert AaronFeickert mentioned this pull request Nov 8, 2023
Closed
@github-actions GitHub Actions
Copy link

Test Results (CI)

1 245 tests   1 245 ✔️  14m 30s ⏱️
     39 suites         0 💤
       1 files           0 ❌

Results for commit 652e49a.

@github-actions GitHub Actions
Copy link

Test Results (Integration tests)

34 tests  +34   34 ✔️ +34   17m 16s ⏱️ + 17m 16s
11 suites +11     0 💤 ±  0 
  2 files   +  2     0 ❌ ±  0 

Results for commit 652e49a. ± Comparison against base commit 1993bef.

@hnidoaht-101
Copy link
Contributor Author

hi @stringhandler as discussed, please feel free to take over my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hnidoaht-101 @ghpbot-tari-project