fix: ban peers if they send a bad protobuf message #5693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWvheerden
reviewed
Aug 30, 2023
There was a problem hiding this comment.
This looks good. I just have a NIT about IllFormed, as camel case that just reads difficult.
There are some uncommented code to be deleted.
And I created issues for the todos. Todos left in code will stay there, and later get deleted. A todo worth doing, is worth creating a issue for
ghpbot-tari-project
added
P-acks_required
Co-authored-by: SW van Heerden <[email protected]>
Co-authored-by: SW van Heerden <[email protected]>
Co-authored-by: SW van Heerden <[email protected]>
Co-authored-by: SW van Heerden <[email protected]>
Co-authored-by: SW van Heerden <[email protected]>
Co-authored-by: SW van Heerden <[email protected]>
Co-authored-by: SW van Heerden <[email protected]>
SWvheerden
previously approved these changes
Aug 30, 2023
ghpbot-tari-project
removed
the
P-reviews_required
ghpbot-tari-project
added
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Propagate errors in decoding protobuf messages and conversions higher up so that nodes can ban them
Motivation and Context
Bad messages were previously ignored and could just fill up a node's buffers. This PR allows the nodes to ban more messages from those peers.
How Has This Been Tested?
Tested locally and cargo test
What process can a PR reviewer use to test or verify this change?
This is pretty tough to test, you might have to try connect an old node to this peer
Breaking Changes