Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(fix): update miner filename #5266

Merged

Conversation

leet4tari
Copy link
Contributor

Description
update miner filename so release has unique filename per arch

Motivation and Context
currently release has only two miner files, which is broken as we should have a file per arch.

How Has This Been Tested?

Built in local fork

What process can a PR reviewer use to test or verify this change?

Look at artifacts and see miner filenames match artifacts.

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghpbot-tari-project ghpbot-tari-project added the P-acks_required Process - Requires more ACKs or utACKs label Mar 24, 2023
@SWvheerden
Copy link
Collaborator

ACK

@ghpbot-tari-project ghpbot-tari-project removed the P-acks_required Process - Requires more ACKs or utACKs label Mar 29, 2023
@SWvheerden
Copy link
Collaborator

ACK

@stringhandler stringhandler added the P-merge Process - Queued for merging label Mar 30, 2023
@SWvheerden SWvheerden merged commit dfc17cb into tari-project:development Mar 31, 2023
agubarev pushed a commit to agubarev/tari that referenced this pull request Mar 31, 2023
Description
update miner filename so release has unique filename per arch

Motivation and Context
currently release has only two miner files, which is broken as we should
have a file per arch.

How Has This Been Tested?
---
Built in local fork

What process can a PR reviewer use to test or verify this change?
---
Look at artifacts and see miner filenames match artifacts.

Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-merge Process - Queued for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants