fix(wallet): add default value for wait stage #4089
Conversation
base_layer/wallet/src/config.rs
Outdated
| @@ -93,7 +93,7 @@ impl Default for WalletConfig { | |||
| password: None, | |||
| contacts_auto_ping_interval: Duration::from_secs(30), | |||
| contacts_online_ping_window: 30, | |||
| command_send_wait_stage: String::new(), | |||
| command_send_wait_stage: "Broadcast".to_string(), | |||
There was a problem hiding this comment.
Instead of a string is this something that makes sense to be an enum. Do we have a set of common values?
There was a problem hiding this comment.
I get your point. I opted for the simplest solution (string) as:
- The enum already exists (
TransactionStage) and is defined in thetari_console_walletapplication. I didn't use it because it doesn't feel right to include a dependency from an application (tari_console_wallet) into the base layer wallet. - Another option could be to move the whole enum definition into the base layer wallet...this could do but again I feel this may be breaking a bit the separation of concerns between the base layer and the applications.
I'm open to suggestions
There was a problem hiding this comment.
I opted for the simplest solution (string)
I get this. Now that I know it does exist somewhere I understand the usage.
Another option could be to move the whole enum definition into the base layer wallet...this could do but again I feel this may be breaking a bit the separation of concerns between the base layer and the applications.
For the sake of conversation though, this doesn't feel wrong. We're introducing the concept into the base layer wallet via the string anyway. The base layer wallet is a dependency of the console wallet. If we moved the enum up a layer we haven't created or broken any new separation of concerns anymore than adding the string does.
Again- just for conversations sake. No change request required.
There was a problem hiding this comment.
The base layer wallet is a dependency of the console wallet. If we moved the enum up a layer we haven't created or broken any new separation of concerns anymore than adding the string does.
You convinced me ;)
Makes sense, I will do that
There was a problem hiding this comment.
Yeah, I'm not really happy about the console wallet config settings being in the WalletConfig struct. It's not 100% correct, but I put them there as a first step. They should actually come out and be put into a local config struct for the console wallet. Given that, this PR is correct. Happy to merge
utACK
Description
Setting the default value of the wallet's config option
command_send_wait_stageasBroadcast.Motivation and Context
The wallet in command mode is failing with the default config, due to empty default value for
command_send_wait_stage. But the value should beBroadcastby default as specified in all theconfig.tomlfiles.How Has This Been Tested?