test: add more wallet ffi testing #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding more FFI test.
Motivation and Context
The ffi-napi is causing internal error (the pointers to the ffi functions gets invalidated) in nodejs when using the ffi destroy functions.
v8::internal::Isolate::ArchiveSpacePerThread+4719
The async calls is solving this (at least it looks like it from the tests I made).
The WalletFFI.js is now generated (the python code is not part of this PR, because it's a mess right now).
How Has This Been Tested?
npm test -- .\features\WalletFFI.feature
Checklist:
developmentbranch.