Remove old unused integration tests #3192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWvheerden
force-pushed
the
sw_remove_old_tests
branch
from
b09d5b8
to
95e9b59
Compare
sdbondi
approved these changes
Aug 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes a bunch of old unused integration tests.
Motivation and Context
We removed these tests because the helper function to make them function was getting too big and bloated and we could not keep updating them. All of these tests are covered in cucumber with much less mocking. All of these tests also require database access that we removed to make database access more secure. These are for example functions such as
spend_utxopreviously they were all exposed but they are now all internal LMDB functions and we only have access to functions such as add_block which will internally "spend" the utxos.How Has This Been Tested?
Checklist:
developmentbranch.