Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure peers are added to peer list before recovery starts #3186

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Aug 12, 2021

Description

Adds peers before recovery starts

Motivation and Context

Recovery tests fails . Base node connection error to 6ff2c71b55a9c808480a0344d1 (retries 0 of 10: ConnectionFailed: Peer manager error: The requested peer does not exist)

How Has This Been Tested?

Successful recovery test

Checklist:

  • I'm merging against the development branch.
  • I have squashed my commits into a single commit.

@sdbondi sdbondi force-pushed the wallet-recovery-ensure-peers-are-added branch from 1923c74 to 6b23ad1 Compare August 12, 2021 07:31
stringhandler
stringhandler previously approved these changes Aug 12, 2021
@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 12, 2021

PR queued successfully. Your position in queue is: 8

@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 12, 2021

PR is on top of the queue now

@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 12, 2021

PR failed to merge with reason: Some CI status(es) failed
Failed CI(s): ci/circleci: run-integration-tests

@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 15, 2021

Waiting for approval before queuing

@sdbondi sdbondi removed the mq-failed label Aug 16, 2021
@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 16, 2021

Waiting for approval from codeowners

@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 16, 2021

Waiting for approval before queuing

Copy link
Contributor

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM untested

@stringhandler stringhandler merged commit 5f33414 into tari-project:development Aug 17, 2021
@sdbondi sdbondi deleted the wallet-recovery-ensure-peers-are-added branch August 17, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants