fix: handle receiver cancelling an inbound transaction that is later received #3177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipr-za
changed the title
philipr-za
force-pushed
the
philip-cucumber-saf-cancel
branch
6 times, most recently
from
5beb8e8
to
637fab7
Compare
|
Waiting for approval before queuing |
stringhandler
previously approved these changes
Aug 11, 2021
|
PR queued successfully. Your position in queue is: 5 |
stringhandler
changed the title
|
PR is on top of the queue now |
|
PR failed to merge with reason: Some CI status(es) failed |
philipr-za
force-pushed
the
philip-cucumber-saf-cancel
branch
3 times, most recently
from
74929e3
to
4ec7cfa
Compare
This PR addresses the following scenario spotted by @stanimal: - NodeA sends to nodeB(offline) - NodeA goes offline - NodeB receives tx, and cancels it (weird I know) - NodeA comes online and broadcasts the transaction - NodeB is not aware of the transaction, transaction complete for NodeA This is handled by adding logic that if a FinalizedTransaction is received with no active Receive Protocols that the database is checked if there is a matching cancelled inbound transaction from the same pubkey. If there is the receiver might as well restart that protocol and accept the finalized transaction. A cucumber test is provided to test this case. This required adding in functionality to the Transaction and Output Manager service to reinstate a cancelled inbound transaction, unit tests provided for that.
philipr-za
force-pushed
the
philip-cucumber-saf-cancel
branch
from
4ec7cfa
to
a16d04b
Compare
stringhandler
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the following scenario spotted by @sdbondi :
This is handled by adding logic that if a FinalizedTransaction is received with no active Receive Protocols that the database is checked if there is a matching cancelled inbound transaction from the same pubkey. If there is the receiver might as well restart that protocol and accept the finalized transaction.
This required adding in functionality to the Transaction and Output Manager services to reinstate a cancelled inbound transaction
How Has This Been Tested?
A cucumber test is provided to test this case.
Unit tests provided for new functionality in the Output Manager and Transaction Services
Checklist:
developmentbranch.