Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use non-zero exit status when wallet recovery fails #3176

Merged

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Aug 10, 2021

Description

Non-zero error code on failure and return more information about the error.

Motivation and Context

Allow scripts to detect recovery failure

How Has This Been Tested?

Still testing it....

Checklist:

  • I'm merging against the development branch.
  • I have squashed my commits into a single commit.

stringhandler
stringhandler previously approved these changes Aug 10, 2021
Non-zero error code on failure and return more information about the error.
Adds logfile output for processes
Copy link
Contributor

@philipr-za philipr-za left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 11, 2021

PR queued successfully. Your position in queue is: 3

@stringhandler stringhandler changed the title fix(dailies): use non-zero exit status when wallet recovery fails ci: use non-zero exit status when wallet recovery fails Aug 11, 2021
@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 11, 2021

PR is on top of the queue now

@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 11, 2021

PR failed to merge with reason: Some CI status(es) failed
Failed CI(s): ci/circleci: run-integration-tests

@stringhandler stringhandler merged commit fd6d5c6 into tari-project:development Aug 12, 2021
@sdbondi sdbondi deleted the tooling-non-zero-on-fail branch August 12, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants