Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve prune mode to remove panics #3163

Merged
merged 2 commits into from
Aug 10, 2021
Merged

fix: improve prune mode to remove panics #3163

merged 2 commits into from
Aug 10, 2021

Conversation

SWvheerden
Copy link
Collaborator

Description

When requesting pruned data on base_node, the node would panic as it tried to provide pruned data.
Removed this panic and changed requests for TransactionOutputs to PrunedOutputs so that callee functions can decide what to do with the data.
Fixed ignored pruned unit test.
Added in cucumber test to prove nodes cant sync from pruned nodes and neither panics.

Motivation and Context

How Has This Been Tested?

Checklist:

  • I'm merging against the development branch.
  • I have squashed my commits into a single commit.

stringhandler
stringhandler previously approved these changes Aug 6, 2021
View reviewed changes
Copy link
Collaborator

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. In future we might need to think of a better name for the PrunedOutput struct. Perhaps PrunableOutput? idk

@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 6, 2021

PR queued successfully. Your position in queue is: 1

@stringhandler stringhandler changed the title feat: Improve prune mode to remove panics feat: improve prune mode to remove panics Aug 6, 2021
@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 6, 2021

PR failed to merge with reason: Failed due to unknown reason

@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 6, 2021

PR queued successfully. Your position in queue is: 1

@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 6, 2021

PR failed to merge with reason: Failed due to unknown reason

@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 6, 2021

PR queued successfully. Your position in queue is: 2

@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 6, 2021

PR is on top of the queue now

@aviator-app aviator-app bot added the mq-failed label Aug 6, 2021
@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 6, 2021

PR failed to merge with reason: Some CI status(es) failed
Failed CI(s): ci/circleci: run-integration-tests

@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 6, 2021

PR queued successfully. Your position in queue is: 1

@stringhandler stringhandler changed the title feat: improve prune mode to remove panics fix: improve prune mode to remove panics Aug 6, 2021
@aviator-app aviator-app bot added the mq-failed label Aug 6, 2021
@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 6, 2021

PR failed to merge with reason: Some CI status(es) failed
Failed CI(s): ci/circleci: run-integration-tests

@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 7, 2021

PR queued successfully. Your position in queue is: 1

@aviator-app aviator-app bot added the mq-failed label Aug 7, 2021
@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 7, 2021

PR failed to merge with reason: Some CI status(es) failed
Failed CI(s): ci/circleci: run-integration-tests

@aviator-app aviator-app bot removed the mq-failed label Aug 10, 2021
@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 10, 2021

PR queued successfully. Your position in queue is: 1

@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 10, 2021

PR failed to merge with reason: Not approved

@aviator-app aviator-app bot removed the mq-failed label Aug 10, 2021
@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 10, 2021

PR is on top of the queue now

@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 10, 2021

PR failed to merge with reason: Some CI status(es) failed
Failed CI(s): test

@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 10, 2021

PR queued successfully. Your position in queue is: 2

@aviator-app
Copy link
Contributor

aviator-app bot commented Aug 10, 2021

PR is on top of the queue now

@aviator-app aviator-app bot merged commit 05f7813 into tari-project:development Aug 10, 2021
@SWvheerden SWvheerden deleted the sw_improve_prune_mode branch August 12, 2021 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SWvheerden @stringhandler