fix: ban peer when Merkle roots mismatch #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
core-block-sync-peer-ban
branch
from
b8fc1a6
to
6fd94a7
Compare
sdbondi
force-pushed
the
core-block-sync-peer-ban
branch
from
6fd94a7
to
39ddd33
Compare
SWvheerden
approved these changes
Aug 6, 2021
Comment on lines
+286
to
+292
| if self.config.sync_peers.contains(&node_id) { | ||
| debug!( | ||
| target: LOG_TARGET, | ||
| "Not banning peer that is allowlisted for sync. Ban reason = {}", reason | ||
| ); | ||
| return Ok(()); | ||
| } |
There was a problem hiding this comment.
Should this logic rather not live in the connectivity manager? Here we don't ban a peer because it is allow listed, but I don't think we have the same logic with propagation, there that peer will get banned.
There was a problem hiding this comment.
This is the force sync peer setting specific to sync, not the seed peers. By default it's empty. So seed peers can get banned, but if you explicitly say "I want to force a sync only from peer X" we never ban them.
|
Waiting for approval before queuing |
stringhandler
approved these changes
Aug 6, 2021
|
PR queued successfully. Your position in queue is: 2 |
|
PR is on top of the queue now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ban peer if block validation fails during block body sync
Motivation and Context
When this error is encountered, the peer sent an invalid block body given the current header chain.
DEBUG Block sync failed: Block validation failed: Block validation error: Mismatched MMR rootsThe node should ban the peer. Previously, the node would encounter this, then retry the same peer,
rinse and repeat - preventing the node from syncing.
How Has This Been Tested?
Not explicitly tested - fairly basic change.
Checklist:
developmentbranch.