fix: remove peer (#5757)

Description --- Fixes remove peer in header sync Fixes latency counter in block sync Motivation and Context --- Header sync should remove the peer for all errors Block sync should only increase the latency once
tari-project · Sep 12, 2023 · 4c48a26 · 4c48a26
1 parent 65c178b
commit 4c48a26
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/base_layer/core/src/base_node/sync/block_sync/synchronizer.rs b/base_layer/core/src/base_node/sync/block_sync/synchronizer.rs
@@ -193,10 +193,6 @@ impl<'a, B: BlockchainBackend + 'static> BlockSynchronizer<'a, B> {
                     } else {
                         self.remove_sync_peer(node_id);
                     }
-
-                    if let BlockSyncError::MaxLatencyExceeded { .. } = err {
-                        latency_counter += 1;
-                    }
                 },
             }
         }

diff --git a/base_layer/core/src/base_node/sync/header_sync/synchronizer.rs b/base_layer/core/src/base_node/sync/header_sync/synchronizer.rs
@@ -151,14 +151,11 @@ impl<'a, B: BlockchainBackend + 'static> HeaderSynchronizer<'a, B> {
                         self.peer_ban_manager
                             .ban_peer_if_required(node_id, &Some(reason.clone()))
                             .await;
-
-                        if reason.ban_duration > self.config.short_ban_period {
-                            self.remove_sync_peer(node_id);
-                        }
                     }
-
                     if let BlockHeaderSyncError::MaxLatencyExceeded { .. } = err {
                         latency_counter += 1;
+                    } else {
+                        self.remove_sync_peer(node_id);
                     }
                 },
             }