fix: shard range computation #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
approved these changes
Dec 7, 2023
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Dec 8, 2023
* development: feat: disable buttons on send, add result dialog (tari-project#813) feat: proper transaction signature and validation (tari-project#791) fix: shard range computation (tari-project#796) feat(integration_tests): new test for downed substates (tari-project#798) chore(deps): Bump docker/setup-qemu-action from 2 to 3 (tari-project#789) chore(deps): Bump openssl from 0.10.59 to 0.10.60 (tari-project#793) fix: propagation (tari-project#799) feat: show substate version in dan wallet ui (tari-project#810) docs(template_lib): add rustdoc documentation (tari-project#824) chore(deps): Bump @adobe/css-tools from 4.3.1 to 4.3.2 in /applications/tari_indexer_web_ui (tari-project#800) chore(deps): Bump @adobe/css-tools from 4.3.1 to 4.3.2 in /applications/tari_validator_node_web_ui (tari-project#801) chore(deps-dev): Bump vite from 4.4.9 to 4.4.12 in /applications/tari_dan_wallet_web_ui (tari-project#818) fix: indexer settings in dan wallet ui (tari-project#805) feat: add transaction json download to ui (tari-project#815) fix: shorten string on small strings (tari-project#823) feat: set refresh balance interval to 5 sec (tari-project#819) chore: comment out flaky test (tari-project#817)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proper shard range computation with tests.
Motivation and Context
There can't be any gap in the shard space.
How Has This Been Tested?
There is a new cargo test.
What process can a PR reviewer use to test or verify this change?
You can run the test:
cargo test --package tari_dan_common_types --lib -- shard_bucket::test::committee_is_properly_computed --exactBreaking Changes