feat: remove achieved difficulty calculation and submit block to base node #70
+22
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed achieved difficulty calculation and submit block to base node, as this will be done by the respective miners/merge mining proxy.
Motivation and Context
It is not efficient for the sha-p2pool to recalculate difficulty nor to submit the mined block with appropriate achieved difficulty to the base node, as the miners already calculate the achieved difficulty and can submit the block directly to the base node instead of via a 3rd party (the sha-p2pool in this case).
How Has This Been Tested?
Waiting for system-level testing.
What process can a PR reviewer use to test or verify this change?
Code review.
Breaking Changes
BREAKING CHANGE:
GetNewBlockResponse
interface change.