Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove achieved difficulty calculation and submit block to base node #70

Draft
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

hansieodendaal
Copy link
Contributor

Description

Removed achieved difficulty calculation and submit block to base node, as this will be done by the respective miners/merge mining proxy.

Motivation and Context

It is not efficient for the sha-p2pool to recalculate difficulty nor to submit the mined block with appropriate achieved difficulty to the base node, as the miners already calculate the achieved difficulty and can submit the block directly to the base node instead of via a 3rd party (the sha-p2pool in this case).

How Has This Been Tested?

Waiting for system-level testing.

What process can a PR reviewer use to test or verify this change?

Code review.

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

BREAKING CHANGE:

  • Miners must submit blocks with appropriate achieved difficulty to the base node directly before submitting it to the sha-p2pool.
  • gRPC GetNewBlockResponse interface change.

Pass through pool and target difficulties to the Monero merge mining proxy and SHA3 miner
@hansieodendaal hansieodendaal marked this pull request as draft September 25, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant