Fix CoreFX test failures

tarekgh · Jul 5, 2016 · 4fd1bfe · 4fd1bfe
1 parent 1f9cd67
commit 4fd1bfe
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 11 deletions.
diff --git a/src/mscorlib/src/System/Text/ASCIIEncoding.cs b/src/mscorlib/src/System/Text/ASCIIEncoding.cs
@@ -66,8 +66,6 @@ public override int GetByteCount(char[] chars, int index, int count)
         [System.Security.SecuritySafeCritical]  // auto-generated
         public override int GetByteCount(String chars)
         {
-            // NOTE: If chars is null, this will throw an ArgumentNullException
-            // with the parameter name "s" rather than "chars"
             return EncodingForwarder.GetByteCount(this, chars);
         }
 
@@ -83,7 +81,6 @@ public override unsafe int GetByteCount(char* chars, int count)
         public override int GetBytes(String chars, int charIndex, int charCount,
                                               byte[] bytes, int byteIndex)
         {
-            // NOTE: Will throw ArgumentNull of "s" is chars is null.
             return EncodingForwarder.GetBytes(this, chars, charIndex, charCount, bytes, byteIndex);
         }
 
@@ -149,8 +146,6 @@ public unsafe override int GetChars(byte* bytes, int byteCount, char* chars, int
         [System.Security.SecuritySafeCritical]  // auto-generated
         public override String GetString(byte[] bytes, int byteIndex, int byteCount)
         {
-            // NOTE: If the byteIndex/byteCount parameters are invalid, this will
-            // throw an ArgumentOutOfRange for "index" or "count" instead of those names.
             return EncodingForwarder.GetString(this, bytes, byteIndex, byteCount);
         }
 

diff --git a/src/mscorlib/src/System/Text/EncodingForwarder.cs b/src/mscorlib/src/System/Text/EncodingForwarder.cs
@@ -63,7 +63,8 @@ public unsafe static int GetByteCount(Encoding encoding, string s)
             Contract.Assert(encoding != null);
             if (s == null)
             {
-                throw new ArgumentNullException("s");
+                string paramName = encoding is ASCIIEncoding ? "chars" : "s"; // ASCIIEncoding calls the string chars
+                throw new ArgumentNullException(paramName);
             }
             Contract.EndContractBlock();
 
@@ -101,15 +102,18 @@ public unsafe static int GetBytes(Encoding encoding, string s, int charIndex, in
             Contract.Assert(encoding != null);
             if (s == null || bytes == null)
             {
-                throw new ArgumentNullException(s == null ? "s" : "bytes", Environment.GetResourceString("ArgumentNull_Array"));
+                string stringName = encoding is ASCIIEncoding ? "chars" : "s"; // ASCIIEncoding calls the first parameter chars
+                throw new ArgumentNullException(s == null ? stringName : "bytes", Environment.GetResourceString("ArgumentNull_Array"));
             }
             if (charIndex < 0 || charCount < 0)
             {
                 throw new ArgumentOutOfRangeException(charIndex < 0 ? "charIndex" : "charCount", Environment.GetResourceString("ArgumentOutOfRange_NeedNonNegNum"));
             }
             if (s.Length - charIndex < charCount)
             {
-                throw new ArgumentOutOfRangeException("s", Environment.GetResourceString("ArgumentOutOfRange_IndexCount"));
+                string stringName = encoding is ASCIIEncoding ? "chars" : "s"; // ASCIIEncoding calls the first parameter chars
+                // Duplicate the above check since we don't want the overhead of a type check on the general path
+                throw new ArgumentOutOfRangeException(stringName, Environment.GetResourceString("ArgumentOutOfRange_IndexCount"));
             }
             if (byteIndex < 0 || byteIndex > bytes.Length)
             {
@@ -293,7 +297,11 @@ public unsafe static string GetString(Encoding encoding, byte[] bytes, int index
             }
             if (index < 0 || count < 0)
             {
-                throw new ArgumentOutOfRangeException(index < 0 ? "index" : "count", Environment.GetResourceString("ArgumentOutOfRange_NeedNonNegNum"));
+                // ASCIIEncoding has different names for its parameters here (byteIndex, byteCount)
+                bool ascii = encoding is ASCIIEncoding;
+                string indexName = ascii ? "byteIndex" : "index";
+                string countName = ascii ? "byteCount" : "count";
+                throw new ArgumentOutOfRangeException(index < 0 ? indexName : countName, Environment.GetResourceString("ArgumentOutOfRange_NeedNonNegNum"));
             }
             if (bytes.Length - index < count)
             {

diff --git a/src/mscorlib/src/System/Text/UTF8Encoding.cs b/src/mscorlib/src/System/Text/UTF8Encoding.cs
@@ -124,8 +124,6 @@ public override int GetByteCount(char[] chars, int index, int count)
         [System.Security.SecuritySafeCritical]  // auto-generated
         public override int GetByteCount(String chars)
         {
-            // NOTE: If chars is null, this will throw an ArgumentNullException
-            // with the parameter name "s" rather than "chars"
             return EncodingForwarder.GetByteCount(this, chars);
         }