Dilution factor fix #956
Merged
Dilution factor fix #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkerzendorf
reviewed
Aug 8, 2019
| 'CSVY field descriptions exist without corresponding csv data' | ||
| if unsupported_columns != set(): | ||
| logger.warning("The following columns are specified in the csvy" | ||
| "model file, but are IGNORED by TARDIS: %s"%(str(unsupported_columns))) |
There was a problem hiding this comment.
Suggested change
| "model file, but are IGNORED by TARDIS: %s"%(str(unsupported_columns))) | |
| "model file, but are IGNORED by TARDIS: {0}".format(unsupported_columns))) |
|
and is this shifting the dilution factor into the code. it doesn't look like it. |
marxwillia
commented
Aug 8, 2019
| @@ -562,8 +580,8 @@ def from_csvy(cls, config): | |||
|
|
|||
| dilution_factor = None | |||
| if hasattr(csvy_model_data, 'columns'): | |||
| if 'w' in csvy_model_data.columns: | |||
| dilution_factor = csvy_model_data['w'].iloc[0:].to_numpy() | |||
| if 'dilution_factor' in csvy_model_data.columns: | |||
There was a problem hiding this comment.
@wkerzendorf is this what you meant by "shifting the dilution factor into the code?" This is the change that loads the given dilution factor profile into the csvy model.
atharva-2001
pushed a commit
to atharva-2001/tardis
that referenced
this pull request
Oct 1, 2021
* Replaced 'w' with 'dilution_factor' in csvy model * Added Warning for unsupported CSVY columns * Changed supported column checks to use Sets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer use the name 'w' because it is confused with atomic symbol for Tungsten.