-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Radiative recombination #933
Radiative recombination #933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very good - no tests though - but I guess we are forgoing them until everything plays together.
tardis/io/atom_data/base.py
Outdated
|
||
photoionization_data: pandas.DataFrame | ||
A DataFrame containing the *photoionization data* with: | ||
index: no index; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really?
|
||
logger = logging.getLogger(__name__) | ||
|
||
njit_dict = {'fastmath': False, 'parallel': False} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should think if we want to have a central one
@@ -275,3 +301,20 @@ class PartitionFunction(ProcessingPlasmaProperty): | |||
def calculate(self, level_boltzmann_factor): | |||
return level_boltzmann_factor.groupby( | |||
level=['atomic_number', 'ion_number']).sum() | |||
|
|||
|
|||
class ThermalLTEPartitionFunction(PartitionFunction): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite clear why we need to have them called ThermalLTE
- as LTE
means Local Thermal Equilibrium
class TInner(Input): | ||
outputs = ('t_inner',) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
streber!
No description provided.