Add capability to store information about the plasma state during iterations #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just extended test_simulation.py to include a check for the newly stored information of the plasma state during the iterations. Naturally, I'll need to update the reference data. |
|
@wkerzendorf - next week we should discuss how to best proceed about updating the reference data since multiple PRs require this step. |
chvogl
requested changes
Aug 2, 2018
docs/running/access_iterations.rst
Outdated
| ********************************************** | ||
|
|
||
| Currently we store information about the plasma state and the inner boundary | ||
| for each iteration. This is saved in the simulation object and can be accesses |
|
@wkerzendorf - we could start merging this one. How should we proceed? First merge the respective PR on the ref-data repo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the capability to store and later access information about the plasma state during the different Monte Carlo iterations. Specifically, the inner boundary temperature, the dilution factor, the radiation temperature and the electron densities are stored.