Transition from atomic-dataset config option to tardis-refdata #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now config option "atomic-dataset" is changed to "tardis-refdata". This points to Tardis reference files folder .
Using master branch of tardis-refdata repository
|
@wkerzendorf @yeganer You can review this PR. @wkerzendorf Can you merge PR#2 in |
Change args.atomic_dataset to args.tardis_refdata
wkerzendorf
reviewed
Aug 9, 2017
.travis.yml
Outdated
| @@ -20,28 +20,29 @@ env: | |||
| - ASTROPY_USE_SYSTEM_PYTEST=1 | |||
| - SETUP_CMD='test' | |||
| - TEST_MODE='normal' | |||
| - ATOM_DATA_URL='https://github.com/tardis-sn/tardis-atomdata/raw/master/kurucz_cd23_chianti_H_He.h5.zip' | |||
| - TARDIS_REF_DATA_URL='https://github.com/tardis-sn/tardis-refdata.git' | |||
| - TARDIS_REF_VERSION='0.2' | |||
yeganer
suggested changes
Aug 9, 2017
| pytest.config.getvalue('atomic-dataset'))) | ||
| assert os.path.exists(self.atom_data_filename), ("{0} atomic datafiles" | ||
| def setup(self, atomic_data_fname): | ||
| assert os.path.exists(atomic_data_fname), ("{0} atomic datafiles" |
There was a problem hiding this comment.
Please move the check to the fixture
|
@wkerzendorf @yeganer I have updated this PR . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
atomic-datasetconfig option withtardis-refdata. Nowtardis-refdatashould point to Tardis reference folder. Repository Link