Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEP014] [DOC] Updated to_hdf notebook #769

Merged
merged 3 commits into from
Aug 1, 2017

Conversation

vg3095
Copy link
Contributor

@vg3095 vg3095 commented Jul 19, 2017

No description provided.

@wkerzendorf
Copy link
Member

you found some typos? why is this PR here?

@vg3095
Copy link
Contributor Author

vg3095 commented Jul 20, 2017

Previous to_hdf notebook is outdated (link), as I think some functions used in that notebook are deprecated (e.g. legacy_run_simulation) . That`s why I made a PR for that.

@wkerzendorf
Copy link
Member

Looks good from my side. @tardis-sn/tardis-core any one else who wants to sign off?

@wkerzendorf wkerzendorf merged commit cd930a7 into tardis-sn:master Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants