Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEP007] Docs for isotope config #767

Merged
merged 7 commits into from
Jul 19, 2017
Merged

Conversation

vg3095
Copy link
Contributor

@vg3095 vg3095 commented Jul 17, 2017

These are the docs for updated uniform and stratified abundance config options.
To see converted html:
-Stratified
-Uniform

Copy link
Contributor

@unoebauer unoebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @vg3095! I only have one request: we should specify how we treat cases in which an elemental abundance and an isotopic abundance for the same element is provided, e.g.:

  • Ni: 0.3
  • Ni56: 0.1
    This implies, that Ni only refers to stable nickel or better any nickel that is not Ni56 (plese correct me if I am wrong)

vg3095 added 2 commits July 17, 2017 17:21
1. Note specifies the case when elemental and isotopic abundance is specified for the same element
2. Change CSV file used for docs to use space delimiter
3. Update abundances in CSV file, so that it sums to one.
@vg3095
Copy link
Contributor Author

vg3095 commented Jul 17, 2017

@unoebauer I have now added a note related to it, in both the docs file. Link for html output in description is updated.
I have made some more changes,

  • Space seperated CSV file.
  • Update the abundances in CSV file, so that they sum to one.

@wkerzendorf wkerzendorf merged commit 9be16b1 into tardis-sn:decay Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants