[TEP007] [WIP] Isotope Abundances class #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vg3095
changed the title
wkerzendorf
reviewed
Jul 4, 2017
tardis_env27.yml
Outdated
| @@ -14,7 +20,8 @@ dependencies: | |||
| - pytest=3.0 | |||
| - pyyaml=3.12 | |||
| - jsonschema=2.5.1 | |||
|
|
|||
| - libgcc | |||
There was a problem hiding this comment.
can you take this requirement out?
|
@vg3095 please rebase on master |
|
@wkerzendorf I have rebased now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just contains Isotope Abundance class, a simple unit test and changes in tardis environment file.
I am not able to resolve conflict for Mac-OS build for
pyne.pyneis0.5.3, but I have used0.5.0, as0.5.3requires updating almost everything (pandas, numpy, astropy, h5py,etc)cyclusandpyneaschannelsintardis_env27.ymlaspyneis not available through default channellibgccwas also required forpyne. I have not mentioned version no. for it because in case of Linux5.2works , and in case ofMac4.8is available. (I will check it one more time). Without updatinglibgccinLinux,pyneis not properly imported.astropybuild, and If I update it , it will result in updating almost all packages as I said in point 1.I will try to resolve MacOS issue, if anybody as any suggestion, then most welcome.
I have tried various combinations.