Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEP014] Change name of HDFWriter to HDFWriterMixin #749

Merged
merged 1 commit into from
Jun 22, 2017
Merged

[TEP014] Change name of HDFWriter to HDFWriterMixin #749

merged 1 commit into from
Jun 22, 2017

Conversation

vg3095
Copy link
Contributor

@vg3095 vg3095 commented Jun 21, 2017

As yeganer said, in PR #747 , we should change the name of HDFWriter to HDFWriterMixin as , this would then correctly reflect that HDFWriter is only a utility class and not the common Root for all our classes

@vg3095
Copy link
Contributor Author

vg3095 commented Jun 21, 2017 •
edited
Loading

Coverage decrease is due to removal of class_properties under Mock Unit tests for HDFWriterMixin. They are actually not required now , as now we are not focusing on from_hdf implementation.

@wkerzendorf wkerzendorf merged commit 4d5a5ae into tardis-sn:master Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vg3095 @wkerzendorf