Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEP014] Update Runner and Spectrum classes to use HDFWriter + Unit Tests #748

Merged
merged 10 commits into from
Jul 17, 2017
Merged

[TEP014] Update Runner and Spectrum classes to use HDFWriter + Unit Tests #748

merged 10 commits into from
Jul 17, 2017

Conversation

vg3095
Copy link
Contributor

@vg3095 vg3095 commented Jun 20, 2017

No description provided.

@vg3095
Copy link
Contributor Author

vg3095 commented Jun 20, 2017

Don`t review it yet. Will update after PR #747 is merged.

@vg3095 vg3095 force-pushed the runner_hdf branch 3 times, most recently from 49b2f92 to c8c9555 Compare June 23, 2017 09:56
@vg3095
Copy link
Contributor Author

vg3095 commented Jun 23, 2017

@wkerzendorf Please review.

@vg3095 vg3095 mentioned this pull request Jun 23, 2017
Closed
yeganer
yeganer reviewed Jun 23, 2017
View reviewed changes
tardis/montecarlo/tests/test_spectrum.py Outdated
def to_hdf_buffer(hdf_file_path,spectrum):
spectrum.to_hdf(hdf_file_path, name='spectrum')

spectrum_attrs = ['_frequency', 'luminosity']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use TARDISSpectrum.hdf_properties here. That way we don't have to update the tests if we change the hdf_properties.

@yeganer
Copy link
Contributor

yeganer commented Jun 23, 2017

Overall this looks very good.

However you have old commits in there which use HDFWriter instead of the mixin. While this is not a major problem due to all changes being merged together it might be a problem if we ever have to use git bisect again. So I'd suggest to git rebase -i upstream/master and edit the commits in question so that at least running the tardis commandline script is possible without errors.

@wkerzendorf wkerzendorf merged commit f4662e2 into tardis-sn:master Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeganer yeganer yeganer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vg3095 @yeganer @wkerzendorf