Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test for untested method of montecarlo simulation code #718

Merged
merged 1 commit into from
May 23, 2017

Conversation

suyashgupta20
Copy link
Contributor

This PR will contain the test methods for the untested C-functions used in montecarlo simulation code.

@suyashgupta20 suyashgupta20 changed the title Unit test for untested method of montecarlo/src/cmontecarlo.c Unit test for untested method of montecarlo simulation code Mar 23, 2017
@wkerzendorf
Copy link
Member

@chvogl can you look at this?

@chvogl
Copy link
Contributor

chvogl commented May 22, 2017

@wkerzendorf Looks good to me. We should possibly add an additional blank line before the function definition to be consistent with the rest of the formatting.

@@ -380,6 +380,32 @@ def test_line_search(nu, nu_insert, number_of_lines, expected_params):
assert obtained_result.value == expected_params['result']
assert obtained_tardis_error == expected_params['ret_val']

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add additional blank line.

@unoebauer unoebauer merged commit 8215aa0 into tardis-sn:master May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants