New configuration style #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The examples look good to me. I've not digested the changes to the code readers themselves. |
|
|
||
| return element_string[0].upper() + element_string[1:].lower() | ||
| add_one: boolean, default: True |
There was a problem hiding this comment.
Why we need add_one. If num > 0, as it should be, it is redundant.
There was a problem hiding this comment.
Well this was born out of the necessary that we want to have x number of bins. If I do x points then I only have x-1 number of bins. Does that make sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed at the meeting, I have restructured the configuration to the new Paper 1 v1.0 configuration.
This PR also adds a large variety of tests that make sure that the paper configuration file can be read. It also tests several of the ascii readers with test files.
@ssim, @mklauser can you check it and sign off on it?