Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ignoring model tests #704

Merged
merged 1 commit into from
Jan 31, 2017
Merged

Fix ignoring model tests #704

merged 1 commit into from
Jan 31, 2017

Conversation

ftsamis
Copy link
Member

@ftsamis ftsamis commented Jan 28, 2017

When converting model to a package and transferring tests to create the model/tests/test_base.py I forgot to also make the tests folder a package by creating an __init__ module. As a result, pytest didn't include the test_base.py unit tests.

@ftsamis ftsamis requested a review from wkerzendorf January 28, 2017 22:37
@ftsamis
Copy link
Member Author

ftsamis commented Jan 28, 2017

The good news is that this is passing!

@ftsamis ftsamis added the ready label Jan 31, 2017
@wkerzendorf wkerzendorf merged commit 7baf69d into tardis-sn:master Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeganer yeganer yeganer approved these changes

@wkerzendorf wkerzendorf Awaiting requested review from wkerzendorf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ftsamis @yeganer @wkerzendorf