-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sigma_T from astropy constants instead of a hardcoded value #688
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the reference date files.
@yeganer Not sure what you are referring to. Do you mean the test_cmontecarlo module? If so, done. |
No, I mean |
@wkerzendorf As @yeganer pointed out someone would have to update the reference data files ( |
I'd still like to merge this. Let's resolve the conflicts and update the reference data. |
I am a bit puzzled why some of the test differ by so much since the change in the value of the Thomson cross section is really minuscule: Before we used the hard-coded value of
Now, we rely on astropy.constants, which includes a value for the Thomson cross section of
in version 1.3.3. This is a change on the level of 1e-6. Yet, in some tests, the differences to the reference values are on the per cent level. Any thoughts on this, @wkerzendorf, @chvogl? |
Closing. Work continues in PR #863 |
Astropy now has a constant defined for sigma_thomson. This PR replaces the hardcoded value with it.
Props to @chvogl for discovering this.
For tardis_example outputs before and after this patch see: https://gist.github.com/ftsamis/eccbcc1b2a29053a412a2d74e5a11e7f