Reimplement tests for the atomic module #648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the tests from
atomicchecks some values fromatom_data.h5. But this hdf file is outdated and not used in the example config anymore (see also #521).Instead of checking
atom_data.h5this PR checkschianti_he_db.h5(and replaces this file with the carsus version). As suggested by the name, this hdf file has only data for He.chianti_he_db.h5is not created only for the purposes of testing theatomicmodule; it is also used intest_plasma_simple.Perhaps, we might want to create a more complete hdfstore for the unit testing.