Fix path of CSS and JS files used in html report. #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,6 +33,7 @@ | |||
| from socket import gaierror | |||
|
|
|||
| from py.xml import html, raw | |||
| import pytest_html | |||
| from pytest_html.plugin import HTMLReport | |||
There was a problem hiding this comment.
I'd add import __name__ as pytest_path
There was a problem hiding this comment.
I assume that you mean pytest_html.__name__. I'm changing it. 😀
kdexd
force-pushed
the
dokureport-css-js-fix
branch
from
6909501 to
343812b
Compare
kdexd
force-pushed
the
dokureport-css-js-fix
branch
from
343812b to
a4e5ff8
Compare
|
@tardis-sn/tardis-core I'm happy to merge. This is a small bugfix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tardis/tests/tests_slow/report.py:
and
...read from the
pytest-html's files.But here,
__name__= 'tardis/tests/tests_slow/report', which is incorrect.So it is changed to
pytest_html.__name__for avoidingOSError.