Initial laydown of comparison plots for TestW7. #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdexd
changed the title
kdexd
force-pushed
the
comparison-plots
branch
6 times, most recently
from
4be6db9 to
9365b03
Compare
| # for different spectrum quantities all in one figure. | ||
| ldl_ax = plt.subplot(111) | ||
| ldl_ax.set_title("Deviation in luminosity_density_lambda") | ||
| ldl_ax.set_xlabel("N-th packet") |
There was a problem hiding this comment.
You are plotting the luminosity density which is used together with the wavelength to form the spectrum.
labeling the x axis N-th packet is wrong.
Plot the data as (x,y) where x is the wavelength and y the luminosity density at that x and call the x-label Wavelength.
|
@yeganer @unoebauer is this mergeable - with the notice that we will change the plots later? Are there any serious issues left? |
kdexd
changed the title
|
@wkerzendorf, @karandesai-96 - fine with me. The PR looks good and some aesthetic details or additional plotting capabilities can be added later. Merge at will! |
|
@wkerzendorf @unoebauer Yes I think we can merge this (I'd autosquash it because of all the back and forth during the PR) |
added 3 commits
May 24, 2016 19:51
- A call to this method is made by test_spectrum method which asserts spectrum quantities. - The pass / fail status is mentioned on the plot itself, by passing a boolean parameter 'passed' to plot_spectrum. - plot_spectrum is called in different ways from try and except blocks of test_spectrum, for the same.
- Rename obtained_radial1d_model -> result. - Remove semilog scale from plot due to ValueError.
- Use this fixture in TestW7, by creating per-setup subdirectories (currently only W7, would be enhanced by parametrization later). - Directories are named as per git commit hashes.
ftsamis
pushed a commit
to ftsamis/tardis
that referenced
this pull request
Nov 12, 2016
* Add plot_spectrum method in TestW7 class. - A call to this method is made by test_spectrum method which asserts spectrum quantities. - The pass / fail status is mentioned on the plot itself, by passing a boolean parameter 'passed' to plot_spectrum. - plot_spectrum is called in different ways from try and except blocks of test_spectrum, for the same. * Cosmetic improvements. - Rename obtained_radial1d_model -> result. - Remove semilog scale from plot due to ValueError. * Add fixture for base directory of saving plots. - Use this fixture in TestW7, by creating per-setup subdirectories (currently only W7, would be enhanced by parametrization later). - Directories are named as per git commit hashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new design pattern - having a
plot_foomethod inTestW7class, for eachtest_foomethod. As a first prototype,plot_spectrumhas been added.Checklist holds a track of work done so far and work TODO:
plot_spectrumto generate a plot for deviation inspectrum.luminosity_density_lambdaagainstspectrum.wavelengthis added within.try-exceptand make suitable calls.Future enhancements