Change the way AtomData quantities are initialized #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quantities are initialized as units.Quantity instead of constructing a Quantity by multiplicating with a unit.
astropy<1.1.0 uses a different value for 'u' when converting quantities than the one specified as constants.u. In astropy>=1.1 unit.u is changed to be equal to constants.u. By using constants.u, our results will be independant of the astropy version. This change required an update of the reference-files for test_plasmas_full.py and test_tardis_full.py. Resolves: tardis-sn#564
|
@tardis-sn/tardis-core This PR is ready to be merged from my side. |
|
My first thought when looking at this was - why should we care about these minor discrepancies. We could just acknowledge these minor inconsistencies in astropy, update the test baseline data when we move to astopy>=1.1 and be done with it. However, given the small changes in the code base which are necessary to fix it properly, I am fine with merging this PR. |
|
For now I'm against merging this PRs. I think we should wait for the detailed integration tests. I don't believe this is currently necessary to change this as we can keep the astropy version fixed below 1.1. |
|
I agree with @wkerzendorf - let's wait for now |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
astropy<1.1.0 is uses a different value for u for converting quantities
than the one specified in constants.u.
In astropy>=1.1 this is changed so that constants.u is always used. By
making this change we are independent of future changes.
Additionally the other quantities are changed to use units.Quantity for
initialization.