Updates to He NLTE treatment. #542
Conversation
|
@aoifeboyle is this the new code that is used to make the paper. Why doesn't it pass? |
|
Hi @wkerzendorf. Sorry, busy with other stuff. Will add this to the to-do list but might need to wait til the weekend. I changed the |
…- being tested now
|
@wkerzendorf How is this as far as removing the duplicate code? |
|
it's still showing duplicates. but we can look at that later. |
|
@wkerzendorf Does that mean we can merge? |
|
@aoifeboyle We should get rid of them - if we sit together this should not take much longer than an hour. 13.30 today? |
| """ | ||
| Calculates the He III level population values. | ||
| """ | ||
| zeta = PhiSahaNebular.get_zeta_values(zeta_data, 2, t_rad)[1] | ||
| he_three_population = (2 / electron_densities) * \ | ||
| he_three_population = 2 * \ |
There was a problem hiding this comment.
You can wrap the whole equation in () then you don't need \ at the end of line which should be avoided.
There was a problem hiding this comment.
Ok, sure. What's the difference?
There was a problem hiding this comment.
To me \ at the end of a line looks ugly and PEP recommends to use ( ) instead.
The added benefit of the 2nd approach is that most editors will indent the following lines differently which looks nicer, too.
|
@wkerzendorf Sorry, only saw this yesterday evening. I'm focusing on the draft right now so I think it will have to wait til next week. |
In the process of ensuring that the results for my paper were reproducible with the new plasma, I found some discrepancies and made some changes. I think there are parts of this that could be better coded but at least it works. I will try to improve/condense it in a while. This now gives the correct results.
Aoife