Mirroring C enums in Python for CMontecarlo tests. #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 16, 2016 09:21
- Corresponding changes in test_cmontecarlo.py and struct.py also included here.
|
That looks like an interesting addition and makes the code more readable - well done @karandesai-96 |
| from ctypes import c_int | ||
|
|
||
|
|
||
| class EnumerationType(type(c_int)): |
There was a problem hiding this comment.
Normally, when we copy code from the internet we like to attribute it with the original source. In science this is an important part to understand the source of information. Can you add one?
|
Thanks @wkerzendorf. I will work upon the suggestions received here and wrap up here with a couple of docstrings 😉 |
|
I'm signing off on this piece of code. It looks good (as far as I understand). @yeganer - you can merge it tomorrow if you are happy as well. |
|
Looks good to me, I'll merge. |
|
This modification is causing occasional segfaults, so it needs to be modified. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are certain parameters, such as
RPacket.statusandStorageModel.cont_statuswhich are C enum datatypes. Enums were considered asctypes.c_uintorctypes.c_intin Python, and implemented in that manner.This PR adds a new file, enum.py which sets up a mirror for C enums in python. Enums are not supported directly in
ctypesso a Meta Class and corresponding Class were written.Following were mirrored for Python tests and used:
This targets improvement in readability of tests.