Remove rpacket.recently_crossed_boundary flag #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the new distance2boundary calculation, we don't need recently_crossed_boundary flag, so it is removed from all occurences. This flag covered only outward propagating packets which have mu>0 anyway and result in the same calculation. This commit removes that overhead and improves readability of the code.
|
This looks good to me - happy to sign off is someone else is too! |
kdexd
pushed a commit
to kdexd/tardis
that referenced
this pull request
Apr 5, 2016
- tardis-sn#533 removed recently_crossed_boundary flag and was merged. The corresponding declaration was removed from the python counterpart struct of RPacket for restoring builds on travis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new distance2boundary calculation, we don't need recently_crossed_boundary flag, so it is
removed from all occurences.
This flag covered only outward propagating packets which have mu>0
anyway and result in the same calculation. This commit removes that
overhead and improves readability of the code.
This is in line with the discussion in Issue #517 .
If we are not 100% sure that there is no negative side effect, I'd suggest waiting for the improved C tests. Adding simple counters showed that
recently_crossed_boundary == 1impliesmu > 0for all testes setups (w7, abn_tom, example).