Montecarlo progress #485
Montecarlo progress #485
Conversation
|
I'm not sure if we want to have the indentation fix clog up the diff... Also, do we actually have clear C-style conventions, @wkerzendorf, @orbitfold? |
|
yes we do have conventions - @orbitfold ? |
|
Sure, i can delete the indentation fix and make a new PR for it. There were mixed tabs and spaces so i just did |
yeganer
force-pushed
the
montecarlo_progress
branch
from
9958631 to
3c32dd8
Compare
|
We do. We have agreed to follow gnu conventions for C code.
|
|
Also yes. For formatting/conventions/bookkeeping purposes please do a
|
|
Particularly in light of GSoC 2016, but also in general, we should prominently mention and link these conventions. |
yeganer
force-pushed
the
montecarlo_progress
branch
from
3c32dd8 to
41a8277
Compare
This is a quick implementation that prints and updates a status line containing the how many packets are already finished, how many total packets are there and the percentage of finished packets. The format of the statusline can be changed by the gobal macro STATUS_FORMAT. The implmentation is exact when running without OMP and an approximation when activating OMP. This is not garanteed to work bugfree in case the sheduler for the for-loop changes. The alternative would be to have a shared variable but that could lead to a minor performance reduction. Rename progress tracking variable in cmontecarlo.c Change STATUS_FORMAT to look nicer
yeganer
force-pushed
the
montecarlo_progress
branch
from
41a8277 to
c1a316b
Compare
|
@orbitfold @unoebauer @wkerzendorf I'm finished with the implementation. If you have anything to add to the feature, i'd be happy to implement it otherwise please have a quick look and then merge. |
| @@ -829,41 +832,56 @@ montecarlo_main_loop(storage_model_t * storage, int64_t virtual_packet_flag, int | |||
| #ifdef WITHOPENMP | |||
| omp_set_dynamic(0); | |||
| omp_set_num_threads(nthreads); | |||
| #pragma omp parallel | |||
|
|
|||
| #pragma omp parallel firstprivate(finished_packets) | |||
There was a problem hiding this comment.
why is this change in there? I don't think that has anything to do with the logging, right?
There was a problem hiding this comment.
i made finished_packets ( my variable to count ) firstprivate so it won't be uninitialized in the threads. I made it private so it won't impact performance.
|
Tested it with tardis_example and it works both with OMP on and off. |
|
@wkerzendorf, @orbitfold - happy with this? I'd merge |
This is a quick implementation that prints and updates a status line
containing the how many packets are already finished, how many total
packets are there and the percentage of finished packets.
The format of the statusline can be changed by the gobal macro
STATUS_FORMAT.
The implmentation is exact when running without OMP and an approximation
when activating OMP. This is not garanteed to work bugfree in case the
sheduler for the for-loop changes.
The alternative would be to have a shared variable but that could lead
to a minor performance reduction.